gdquest-demos / godot-2d-space-game

A 2D space exploration and mining game made with Godot and our AI framework
MIT License
838 stars 109 forks source link

Change registry to dependency initializer #9

Closed Razoric480 closed 4 years ago

Razoric480 commented 4 years ago

Rather than children polling for objects, objects are provided to the children by an overseer.

This PR is created for potential discussion of pros and cons, improvements, or alternate solutions (and/or to merge if we like it.)

NathanLovato commented 4 years ago

What's the state of this PR?

Razoric480 commented 4 years ago

I believe Razcore mentioned he'd revisit the states, but he hasn't mentioned anything about it. I'd be ready to work with it as-is, though, and I can't think of any other major change.

Razoric480 commented 4 years ago

Razcore has informed me that the PR is ready. The only thing is separating the gun from the movement states, but that will be folded as a minor enhancement into milestone 3.

NathanLovato commented 4 years ago

Thanks!