search

gdquest-demos / godot-3-beginner-2d-platformer

Learn to create a 2d platform game with the Godot game engine. This is a beginner programming tutorial.
MIT License
364 stars 96 forks source link

Add core game elements #15

Closed henriiquecampos closed 5 years ago

henriiquecampos commented 5 years ago

Hey, so this is a more robust PR that addresses the following issues

2

3

4

5

6

7 this one is not complete tho, in this PR there is the assembling of the Level elements. Actual level design will be worked further

8

With that, the core game elements are on place.

So now is a good PR to see things in context, if you could, @razcore-art, review the code structure and overall approach adding comments in the line they refer to, in the files changed tab.

Here go some nice features GitHub offers for reviewing work:

If you want to do some few passes on it, GitHub has a cool feature that allow us to mark which files were already review, so you don't lose track of what files are still left, you don't have to add comments on the files to mark them as reviewed, there is a checkbox on them, and at the top of the files changed tab you can see how many files are still left.

Also, you can write an "overall" review if there is an overall issue you want to point out, e.g. "Fix file X, Y, Z to be compliant to our guidelines". You can use the "Review Changes" button at the very top of the review workspace for this.

Also, I turned on Allow edits from maintainers so you can do some tweaks if you feel like it. This way we don't spend too much time having to wait for me to come back.

I also assigned myself to this PR so when I apply all the changes requested I can merge it already, saving some time.

razcore-rad commented 5 years ago

OK, I went over what you did here, nice work by the way, it was pretty well laid out. Most of the stuff I changed was in the interest of making it more clear or when I saw there's something wrong with the way some Godot functions work or not really wrong, but more like unexpected or not even that, but you'll see what I mean in the comments that I'll write on the files themselves.

henriiquecampos commented 5 years ago

Alright, take a look on the updated files @razcore-art :smile:

razcore-rad commented 5 years ago

Nice, I went through the PR, thanks for the work! I agree, I think it's quite better now overall with all the iterations we did. I also agree with you about the naming on apply_* functions, I'll think about this. Meanwhile I'll approve the merge and we can work on this later.