search

gdquest-demos / godot-3-beginner-2d-platformer

Learn to create a 2d platform game with the Godot game engine. This is a beginner programming tutorial.
MIT License
364 stars 96 forks source link

Die if player is under the camera #40

Closed NoNamePro0 closed 3 years ago

NoNamePro0 commented 3 years ago

Please check if the PR fulfills these requirements:

Related issue (if applicable): #

What kind of change does this PR introduce? One Line in Player.gd which checks a thing.

Does this PR introduce a breaking change? Not really. It's just a small improvement.

New feature or change

What is the current behavior? If Player is falling under the world (TileMap) the Player is falling and falling. The User just can move from left to right or pause the game.

What is the new behavior? The Player dies if it's under 1080 y-Axis.

Other information Example Image (The Ruler is at the location, when player is dieing)

NathanLovato commented 3 years ago

I'm closing this PR as there's been no update. The implementation isn't right for this demo.

Thanks for contributing regardless.