search

gdquest-demos / godot-3-beginner-2d-platformer

Learn to create a 2d platform game with the Godot game engine. This is a beginner programming tutorial.
MIT License
365 stars 96 forks source link

Godot 4 #44

Closed brno32 closed 1 year ago

brno32 commented 1 year ago

Would you accept a PR that updates this project for Godot 4?

NathanLovato commented 1 year ago

While we always appreciate contributions, I think we won't update the main branch of the repository to Godot 4 because it's linked to this old youtube video. So if you contributed a Godot 4 port, we would save it in a secondary branch.

brno32 commented 1 year ago

Since the C# version is in the main branch as a neighbor to the gdscript version, would it make sense to have a godot 4 version in just another folder?

e.g., we'd have game, mono-game, and maybe godot4-game?

NathanLovato commented 1 year ago

Sure! That would work. Such a contribution would be welcome.

brno32 commented 1 year ago

Sure! That would work. Such a contribution would be welcome.

I've opened a draft PR to welcome your feedback. Porting was harder than I thought it'd be 🤣

brno32 commented 1 year ago

done in https://github.com/GDQuest/godot-beginner-2d-platformer/pull/45