search

gdquest-demos / godot-3-beginner-2d-platformer

Learn to create a 2d platform game with the Godot game engine. This is a beginner programming tutorial.
MIT License
364 stars 96 forks source link

Porting to Godot 4 #45

Closed brno32 closed 1 year ago

brno32 commented 1 year ago

Please check if the PR fulfills these requirements:

Related issue (if applicable): #44

Info

Though we've discussed adding a new godot4-game folder, I'm opening this against the game folder so we can see the diff.

I was quite surprised at how large the diff is, but I guess godot 4 uses a much different metadata format for assets than godot 3, so I don't think there's a way around it. It might make sense to maybe only include the gdscript changes just so we can focus on the API changes for now. Any thoughts regarding this unwieldly diff?

brno32 commented 1 year ago

@NathanLovato any thoughts?

NathanLovato commented 1 year ago

Sorry for the slow answer. This PR is on my to-do list, just that this list is a bit long at the moment. Having a big diff is completely fine, please don't worry about it.

I'll test and review this over the weekend. Thanks much for taking the time to port the demo!

brno32 commented 1 year ago

Cool! No worries. In that case, I put everything under the godot4-game folder as discussed. Thanks!

NathanLovato commented 1 year ago

Thanks much for the work!