search

gdquest-demos / godot-3-demos

Dozens of free and open source demos for the Godot game engine, version 3. Head to the link below for newer demos for Godot 4+
https://github.com/gdquest-demos/
MIT License
1.85k stars 978 forks source link

Errors in Finite State Machine demo #33

Closed seanbone closed 5 years ago

seanbone commented 5 years ago

In the Finite State Machine demo (file 2018/04-24-finite-state-machine/player/weapon/sword.gd), there are several errors of the type:

Identifier 'IDLE' is not declared in the current scope.

This is because the two enums are being called incorrectly: syntax changed as of Godot 3.1 alpha 3. I'm also not sure how it would have worked previously (Godot newbie here), since both STATES and ATTACK_INPUT_STATES have an IDLE state, and I'm not seeing how the two should be distinguished in previous Godot versions.

PS: thank you so much for all the work you've put into these demos, as well as your YouTube tutorials. Wonderful resource, makes getting started with Godot super easy and fun!

NathanLovato commented 5 years ago

Thanks much for the report! I opened #41 so we can fix the issue everywhere efficiently, instead of doing it manually for every demo.

seanbone commented 5 years ago

Yeah, that sounds like a much more sensible plan. I might be able to get the ball rolling on that next week.