Adding fps sample - Githubissues

mistertaftcreates commented 5 years ago

I think I'm doing this correctly. Here is the sample I've made so far.

NathanLovato commented 5 years ago

Please don't use spaces in file and folder names.

NathanLovato commented 5 years ago

Hi, I'm just getting to review this now. The previous days have been quite busy.

I'd need a little extra info:

It seems each demo builds upon the previous one, is this correct?
Also, are there more features/bits of code you intend to add?

For a multi-part series that targets beginners like this, a different workflow might be beneficial and more efficient. Having 1 copy of the project for each part means that if we find a bug late, it can be hard to patch all versions. I've faced that with our previous Godot course.

So we could have a dedicated repo for this project that I can add here as a git submodule. There, we can have a branch dedicated to development, where the git history can be natural and have the tutorial version on the master branch, where 1 commit = 1 video or checkpoint for the viewer.

A few more general notes:

For the controls, I'd like us to favor mouse and keyboard first because not all viewers have a gamepad or a desktop-compatible gamepad.
For longer series, it'll be a lot more efficient if you build the final demo first and only that, go through review, and build the steps back afterward. I can show you how to do that with git, and generally help you with that part.

NathanLovato commented 5 years ago

Also, for reviews, I think it'll be faster if we have a place where I can also commit - this way I can make changes directly and comment on the commit so you can see what didn't fit the guidelines or what-not, as it takes less time than asking you to make each change line-by-line.

E.g. things like func generate_hit_effect(hit_position: Vector3, hit_rotation: Vector3), the function you use when shooting, this should be on a gun or something, not on the Demo class. There are a few changes I'd like to make or request, but doing so with a comment for each line is not efficient.

Would this work for you? I can create a repo for this project where we both have access rights

mistertaftcreates commented 5 years ago

Hey there.

I was camping for the long weekend here in the states. I'll address your questions in reverse order, if that works.

1 - I think what would work best for me is for you to create a repo for the project where we both have access rights.

2 - Having you just make changes and comment on the commit works for me as well.

3 - Building the final project was what I was going for, but stopping at what seemed like a logical stopping point. I broke it up like I did more to show you an idea of an outline. I can definitely work differently.

4 - Favoring Keyboard and Mouse is totally fine. I generally get a little nauseous with a mouse which is why I personally prefer gamepad. But since this is a beginner series I can definitely focus on the one in order to improve the overall flow.

5 - As far as features go, I think that was all that I wanted. The main part that isn't working that I haven't looked into at all since I made it is the decals from the 3d sprite. It works on two sides, but not others. I'm very open to any other features that you think should be in there, though.

James

On Fri, Aug 30, 2019 at 9:39 AM Nathan Lovato notifications@github.com wrote:

Also, for reviews, I think it'll be faster if we have a place where I can also commit - this way I can make changes directly and comment on the commit so you can see what didn't fit the guidelines or what-not, as it takes less time than asking you to make each change line-by-line.

E.g. things like func generate_hit_effect(hit_position: Vector3, hit_rotation: Vector3), the function you use when shooting, this should be on a gun or something, not on the Demo class. There are a few changes I'd like to make or request, but doing so with a comment for each line is not efficient.

Would this work for you? I can create a repo for this project where we both have access rights

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GDquest/Godot-engine-tutorial-demos/pull/53?email_source=notifications&email_token=AJNWF35BSYMOQ6YVMBVTKG3QHE5MRA5CNFSM4IPHFOZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5SAMGI#issuecomment-526648857, or mute the thread https://github.com/notifications/unsubscribe-auth/AJNWF3ZDLTYMR73RKYHIWLTQHE5MRANCNFSM4IPHFOZQ .

NathanLovato commented 4 years ago

Closing this PR as the project has its own repository: https://github.com/GDQuest/godot-3d-fps-beginner-series

gdquest-demos / godot-3-demos

Adding fps sample #53