search

gdquest-demos / godot-4-3d-third-person-controller

Godot 4 demo with a plug-and-play 3D Third-Person Shooter (TPS) character controller inspired by games like Ratchet and Clank.
MIT License
714 stars 80 forks source link

Camera rotation speed is effected by framerate. #19

Closed MJBrune closed 2 months ago

MJBrune commented 1 year ago

I'd like to see the camera rotation improved in GDQuest's third-person controller. Currently, it's affected by framerate. If you turn off VSync and set max fps to 1000 (or another high number) then if you get around 400 FPS (try an empty scene) you can see the camera rotation speed become very slow. Likewise limiting to 10 FPS will speed up the camera rotation.

I noticed you multiply the rotation_input by the delta time of the physics process. This doesn't do anything though since the physics process function is fairly statically called. If you place the code to move the camera in the _process then the delta is representative of the current frame rate and thus your camera will no longer be affected by framerate.

If this is a change you'd like to see made, I'd be happy to make it.

NathanLovato commented 2 months ago

Thanks for the report and sorry for the delay; I forgot about the issue at the time. Generally-speaking bug fixes are always welcome! And contributions, like you taking the time to explain the issue. Thanks!