search

gdquest-demos / godot-4-3d-third-person-controller

Godot 4 demo with a plug-and-play 3D Third-Person Shooter (TPS) character controller inspired by games like Ratchet and Clank.
MIT License
710 stars 78 forks source link

Update to latest version of Godot 4 #20

Closed CZakarya closed 1 year ago

CZakarya commented 1 year ago

Changes have been made in Godot 4 so that this project doesn't work in the latest version of Godot.

tung-nt-niteco commented 1 year ago

Yeah, there are a couple of things to change, including this one: https://github.com/gdquest-demos/godot-4-3d-third-person-controller/issues/18

Then, set_target_location -> set_target_position get_next_location -> get_next_path_position

It worked for me after all.

NathanLovato commented 1 year ago

The project is running fine for our team in Godot 4.0.2, the latest stable version. There are no instances of get_next_location() or set_target_location() in the source code. Did you guys pull the latest changes? It sounds like you might have downloaded an older copy of the source code.

akien-mga commented 1 year ago

I confirm that it's working fine for me in the latest main branch of this repo with Godot 4.0.2.

The only issues I found are a couple warnings of changed/not-found UID, and emission_energy_multiplier changing in one material when opening it in the editor.

NathanLovato commented 1 year ago

Thanks, closing for now as it seems to be working fine around the team. I invite you to re download the code to get the latest version, and if it fails to open please let me know and we'll reopen the issue.

tung-nt-niteco commented 1 year ago

Noticed that I downloaded the code by clicking the button on https://www.gdquest.com/news/2022/12/godot-4-third-person-controller/, that is why I got the old code :)

NathanLovato commented 1 year ago

Thanks for mentioning this, I'll update the link!

BillyJoelsNightmareExplosion commented 1 year ago

Thanks for mentioning this, I'll update the link!

Hey just to let you know @NathanLovato, the download link on the site still points to an older version.

Starzky commented 1 year ago

On v4.1.3.stable.official [f06b6836a], the player drops straight through the terrain - progressively, until falling straight out of the bottom of the ground.