search

gdquest-demos / godot-4-new-features

Free and open-source Godot 4 demo scenes to see the new features in action
MIT License
449 stars 45 forks source link

Improve Arabic messages #33

Closed ebraminio closed 1 year ago

ebraminio commented 1 year ago

Just simple and minor orthography fixes in Arabic messages and adding missing markup and punctuations that exists in English messages but not in Arabic ones.

Also adds Arabic long vowels to vowels list to make character's mouth move in Arabic.

While reviewing please note that as Arabic is written from right to left the space before comma is on its right not left so I've removed the one on its right (before) not left that might be confusing to the reviewer but not someone who uses the script everyday.

ebraminio commented 1 year ago

Also is it okay to add another language here?

NathanLovato commented 1 year ago

Thank you for the contribution! Much appreciated. Regarding adding another language, we'd prefer not to add more, as this demo aims to show the support for one latin script (other than English), one CJK language, and one right-to-left language.

NathanLovato commented 1 year ago

GitHub seems to be having some issues at the moment. I can´t merge the PR or push changes right now. I'll try again later.

ebraminio commented 1 year ago

Oh, I almost have forgot this, thanks for considering this 😊

Regarding adding another language, we'd prefer not to add more

That's totally understandable.

GitHub seems to be having some issues at the moment. I can´t merge the PR or push changes right now. I'll try again later.

I can rebase if you think is needed. Thanks 😊

NathanLovato commented 1 year ago

Could merge this morning, thanks again for contributing!