gdquest-demos / godot-demos-2022

Free and open-source Godot demos for learning, with guides and tutorials: 2022 edition.
Other
409 stars 41 forks source link

Fix double GDQuestVisualizationTools on HitBox and HurtBox demo #17

Closed henriquelalves closed 2 years ago

henriquelalves commented 2 years ago

Related issue (if applicable): 0

What kind of change does this PR introduce? When testing the "HitBox and HurtBox" demo, I noticed there were two "Visualization Tools" nodes instantiated in the live scene (a "GdQuest[...]" and a "GDQuest[...]" one). It didn't affect the scene, but it was the same script being instantiated twice in Autoload with different names, so I removed the "GdQuest[...]" autoload (since it didn't follow the name convention of the project).

I took the liberty of checking the other demos for this same error, and I changed the "Juicy-Attack" autoload name to also follow the "GDQuest" name convention. If this is not the correct name, I can change it back for both demos!

Does this PR introduce a breaking change? No.

NathanLovato commented 2 years ago

Thanks much!