Color Palette Plugin - Githubissues

gdquest-demos / godot-kickstarter-2019

Create your Own Games with Godot, the Free Game Engine: sources from the January Kickstarter project from GDQuest

MIT License

242 stars 269 forks source link

Color Palette Plugin #23

Closed henriiquecampos closed 5 years ago

henriiquecampos commented 5 years ago

This hopefully closes #20 I added 2 demo palettes to the commit for reference of the .json structure.

These lines can potentially be removed after #21 since it will be the one responsible to manage this

NathanLovato commented 5 years ago

Could you add undo/redo support? I didn't think about mentioning it but every single tool that modifies a node should always support undos. See the UndoRedo object. If you need a hand ask anytime.

NathanLovato commented 5 years ago

Also please refactor to make the code follow the styleguide. Mainly:

Use type hints
Use onready variables to get nodes only upon initializing the plugin. Having these variables at the top helps to track dependencies in the code, and in general it's a good practice for performances.

henriiquecampos commented 5 years ago

Done, I'm just not sure about this line in particular

onready var _interface: ColorPalette setget , get_interface

This variable is actually set in _enter_tree, I only made it onready because it is a dependency of the plugin, and I couldn't find a better way to communicate this dependency. Shall we keep it like this or is better to change it to a simple var and add a comment talking about said dependence relation?

NathanLovato commented 5 years ago

All good :)