search

gdquest-demos / godot-make-pro-2d-games

A-RPG demo made with Godot, MIT-licensed, from our Godot course
MIT License
995 stars 108 forks source link

Port to Godot 3.1 #97

Closed NathanLovato closed 5 years ago

NathanLovato commented 5 years ago

Godot 3.1 doesn't support different function signatures when you override a method. E.g.

# Menu.gd
func initialize(args=[]):

Overriding it as

# ShopMenu.gd
extends Menu.gd

func initialize(shop, buyer, items):

Will give this error:

Parser Error: Function signature doesn't match the parent. Parent signature is: 'Variant initialize(Variant=default)'.

Clooloo commented 5 years ago

yea same

NathanLovato commented 5 years ago

Done with c2133ce124ec16f875be29bc36065e2fcab9cecf, although a handful of bugs are left on the UI front