search

gdquest-demos / godot-platformer-2d

2d Metroidvania-inspired game for the 2019 GDquest Godot Kickstarter course project.
MIT License
623 stars 74 forks source link

Fix PassThrough not working #147

Closed henriiquecampos closed 5 years ago

henriiquecampos commented 5 years ago

Close #146

I need suggestions for the name, tho. Maybe adding an Enabler as the suffix can do the trick.

As for being tied to a State, I think it still needs to be discussed, as it may imply in changes in such State node type, as mentioned here

Also since the logic that made the character actually fall was bound to the fact that the player pressed jump, the PassThrough became aware of the States to perform such task itself, which I think is not desirable, so what do you think about having a signal communicating that the pass-through was performed, and use this signal to change the state instead?

NathanLovato commented 5 years ago

Looking good, thanks for your work!