gdquest-demos / godot-platformer-2d

2d Metroidvania-inspired game for the 2019 GDquest Godot Kickstarter course project.
MIT License
623 stars 74 forks source link

Fixes to Levels, background and debug #177

Closed henriiquecampos closed 4 years ago

henriiquecampos commented 4 years ago

Please check if the PR fulfills these requirements:

Related issue (if applicable):

henriiquecampos commented 4 years ago

I couldn't fire the hook with the mouse at anything, however - work in progress issue?

I couldn't as well, maybe it has to do with an WIP issue not related here? I didn't work with hook or anything related I guess.

NathanLovato commented 4 years ago

As I mentioned earlier, for small bugs or features, you don't need to create a branch and a PR. Things like toggling fullscreen etc.

NathanLovato commented 4 years ago

What I mean is: you can ask for review or commit in a branch for things where you know you need review, for the rest you can commit directly.

henriiquecampos commented 4 years ago

As I mentioned earlier, for small bugs or features, you don't need to create a branch and a PR. Things like toggling fullscreen etc.

I don't have permission to Godot Platformer, only to Godot Platformer Beginner. And @Razoric480 asked me to make a PR for 2 features that were in different commits spaced by other features, so I made a PR with everything.

I was commiting to master directly, but it would take time to cherrypick the commits with the features he wanted to the PR branch.

NathanLovato commented 4 years ago

Thanks, I'll merge for now, and check that the team has write access to the repo!