search

gdquest-demos / godot-procedural-generation

Procedural generation algorithms and demos for the Godot game engine
Other
1.53k stars 84 forks source link

Port to Godot 4.0 #10

Closed Omiod closed 1 year ago

Omiod commented 1 year ago

I'm submitting a...

NathanLovato commented 1 year ago

Good news for you! Contributor @tlobig has been porting this project to Godot 4: https://github.com/tlobig/godot-procedural-generation/tree/godot4update

I haven't had the time to review this yet but Godot 4 support is in the works

tlobig commented 1 year ago

thanks for the mention @NathanLovato I'm close to done with the first pass, only the last to parts of the course are not yet ported. The code has a lot of comments to help with review, but should go before a merge. Finally the new capabilities of Godot 4 enable a few ways to better structure the code and I will not have fully leveraged this on the first pass.

NathanLovato commented 1 year ago

Don't hesitate to open a pull request once you'd like a review. We can directly refactor on top of your work + share insights on the changes if you're comfortable with that, which is the most efficient review option, or we can provide comments for you to make changes yourself if you prefer.

Omiod commented 1 year ago

Awesome! Thank you very much!

tlobig commented 1 year ago

Let's go ahead an change it together. I'd love some constructive feedback. I expect to be done with infinite worlds and cellular automota in the next few days. The course text will also need to be updated eventually.

tlobig commented 1 year ago

I touched everything in the godot folder and have even started on a second pass through, tidying up some things in the basic dungeon and random walker parts. I will now await further direction before cleaning up the rest. Meanwhile all demos are in a usable state with Godot 4.0 stable

Omiod commented 1 year ago

Awesome! Most of them works! But some like the MSTDungeon and RandomWalker have the error "Parser Error: Unable to iterate on object of type "Node"."

tlobig commented 1 year ago

Thank you for testing. Try RandomWalker again, I think the error you mention is only in MSTDungeon and it looks like a new issue that came with the stable 4.0 release.

tlobig commented 1 year ago

I pushed an update for MSTDungeon, it still crashes if I remove the print statement print("_add_rooms") which is super weird. Could be anything. So, it works now, but this lurking bug needs to be squashed.

Omiod commented 1 year ago

Thank you! RandomWalker works fine. That bug is quite weird indeed.

NathanLovato commented 1 year ago

@tlobig thank you so much! I really want to give you a proper review quickly but I'm still overloaded with work with GDC next week. I'll ask the teammate who put the most work on this project if he can handle that. He works at GDQuest Thursday to Saturday.

tlobig commented 1 year ago

@NathanLovato please don't stress yourself out about this review. You obviously have to have your mind on GDC now. All in good time. I just wish I had more time to spend on things like these - is all I'll allow myself to publicly state.

jipiboily commented 1 year ago

Any news on review and the update to the course by any chance? :)

tlobig commented 1 year ago

it's done for months, the issue should be closedAm 07.10.2023 01:31 schrieb JP Boily @.***>: Any news on review and the update to the course by any chance? :)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

NathanLovato commented 1 year ago

Thanks for the reminder to close! @jipiboily see the folder godot4/ that contains the Godot 4 port of the demos