Closed tlobig closed 1 year ago
PR is still in draft, last two parts of the course are missing
commits should be squashed and comments cleaned before merging
Thanks much! Just a heads up, I'll be away for the weekend, only working on project management and email/communication. I'll do code reviews again after that.
I included this suggested bugfix in the SpaceInfiniteGeneration/PersistentWorldGenerator part, after amending it to work properly: https://gdquest.mavenseed.com/community/14469-bug-in-_find_sector
first pass done, review of changes can begin.
Just asked Razvan, he confirmed he'll review this as I currently have too much on my plate (still crunching, not very efficient anymore). He works from Thursday to Saturday so please note it might be a couple of days before he gets to this.
Merged as #12
Please check if the PR fulfills these requirements:
Related issue (if applicable): #10
What kind of change does this PR introduce? Course demo code runs in Godot 4.0 stable
Does this PR introduce a breaking change? Breaks compatibility with Godot 3.x
New feature or change
All code should work with Godot 4.x (4.0 stable as of writing)
TODO