search

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access
Other
62 stars 50 forks source link

Send "--bindir" to zziptests.py #103

Closed vaukai closed 3 years ago

vaukai commented 3 years ago

Works with cmake, not with ./configure Provides simpler coding, easier to read

gdraheim commented 3 years ago

I dont understand the purpose of removing the DEPENDS on the test-binaries which are actually used in the testsuite.

=> DEPENDS ../bins/zzcat ../bins/zzdir ../bins/zziptest ../bins/zzxorcat ../bins/zzxorcopy

vaukai commented 3 years ago

I dont understand the purpose of removing the DEPENDS on the test-binaries which are actually used in the testsuite.

After injecting "--bindir=${bindir}" in test/CMakeLists.txt and replacing all occurences of "../{exe}" with "{exe}" in test/zziptests.py, those DEPENDS are no longer needed.

This patch is helpful/essential for distributions like Gentoo where CMAKE_BINARY_DIR is different from CMAKE_SOURCE_DIR.