search

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access
Other
62 stars 50 forks source link

Use portable switches for `ln` #111

Closed jurajlutter closed 3 years ago

jurajlutter commented 3 years ago

On platforms (SystemV-derived, like illumos or SmartOS), there is no -v flag for ln, causing the build to fail. The solution is to not use -v.

gdraheim commented 3 years ago

Please check the 'develop' branch where I have extended the cmake checks looking for "ln -verbose".

I will cherry-pick that to the master branch if it fixes your problem.

Thanks in advance.

jurajlutter commented 3 years ago

FWIW, my proposed patch for pkgsrc is:

https://pkgsrc-smartos.wilbury.net/patches/NetBSD/archivers_zziplib.diff

this also addresses a problem on Darwin.

jurajlutter commented 3 years ago

@gdraheim works.

gdraheim commented 3 years ago

Thanks for pointing out that the implementation is required in zzipwrap/cmake as well.

I have added it there, and both patches were cherry-picked to to /master

gdraheim commented 3 years ago

You had also mentioned a problem on Darwin but I don't see a difference over the current branches. I guess I can close it here.