Open gdraheim opened 3 years ago
As I said before, it is not necessary to take mingw as a special case. I have already done a little temporary patching to remove the number in libraries, here https://github.com/msys2/MINGW-packages/pull/8746.
@Biswa96 - I am not sure if it would to have a general case to remove the libname-REL.lib feature as it may break compatibility with older versions of the lib. I would add it as a general option but as you have your own patch I'll leave as it is now.
Agree. BTW, just for testing, I have tried to build the latest master branch and I got this error:
CMake Error at zzip/cmake_install.cmake:130 (file):
file INSTALL cannot read symlink "F:/zziplib/bin/zzip/libzzip.dll" to
duplicate at "F:/zziplib/bin/install/clang64/lib/libzzip.dll": File exists.
Call Stack (most recent call first):
cmake_install.cmake:42 (include)
Just FYI, mingw does not follow .lib extension. It has .a for static lib, .dll.a for import library, .dll for dynamic lib. File list here https://packages.msys2.org/package/mingw-w64-x86_64-zziplib?repo=mingw64
Another option would be to remain -lzzip-0
in pkgconfig files. Creating symbolic link in Microsoft Windows is a bit sketchy.
Yeah the generated pkgconfig file (/usr/lib/pkgconfig/zzip*.pc) have the wrong libs in it. Like zziplib.pc should have -lzzip-0 in it, not -lzzip. (zziplib 0.13.74)
The mingw guys have show that a static-lib build fails as it only has a zzip-0.a being around while pkgconfig referes to zzip.a
See pull request #116 for discussions.
This comes from having the symlink "ln -s libzzip-0.so libzzip.so" activated only for shared lib builds.
So the whole RELNUM and non-rel-alias setup should be revisited.