Fix detecting if the host build system is a unix-like system

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access

Other

60 stars 50 forks source link

Fix detecting if the host build system is a unix-like system #136

Closed vividos closed 1 year ago

vividos commented 2 years ago

and has UnixCommands package available. This PR fixes #133 where I want to cross-compile to Android using a Windows machine.

vividos commented 2 years ago

@gdraheim what do you think?

dg0yt commented 1 year ago

I think this change is invalid. Given the original issue #25187 (Android cross build on Windows), the proper general solution would be using portable CMake scripts instead of bash scripts which cannot be executed without MSYS on Windows, for implementing ZZIP_COMPAT, ZZIP_PKGCONFIG and ZZIP_LIBTOOL. (For Android in particular, suffixed .so files are pointless.)

vividos commented 1 year ago

I'm closing this PR as per dg0yt's comment.