search

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access
Other
62 stars 50 forks source link

circular #include for zzip32.h and lib.h #44

Closed feiyunw closed 6 years ago

feiyunw commented 6 years ago

In zzip\zzip32.h:

#ifndef _ZZIP_ZZIP32_H
#define _ZZIP_ZZIP32_H

#include <zzip/lib.h>

In zzip\lib.h

#ifndef _ZZIP_LIB_H /* zzip.h */
#define _ZZIP_LIB_H

#include <zzip/zzip.h>
#include <zzip/plugin.h>
#include <zzip/stdint.h>
#include <zzip/zzip32.h>

These header files include each other. It is not a good smell.

gdraheim commented 6 years ago

I have done a quick codesearch through public (opensource) repositories and it seems that no one has ever used the *32 functions explicitly. So I decided to cut that include out of <zzip/lib.h>.

gdraheim commented 6 years ago

done.