search

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access
Other
62 stars 50 forks source link

zziptests.py don't return non-zero return code on errors and require network access #53

Closed flokli closed 4 years ago

flokli commented 6 years ago

While trying to enable running tests during the build process of the zzlib package in NixOS, I saw tests running through 'successfully' without a non-zero return code, but log showed a lot of tests were failing, due to missing network access in the sandboxed builder.

Can you have a look in why this error is not propagated?

And secondly, as the URLs being downloaded all seem to be POCs from other git repos: Is it possible to simply add these repositories as submodules, and not download them during test phase? This would really help for reproducibility :-)

gdraheim commented 4 years ago

Actually, you need to do something like this

result = Runner(verbosity=opt.verbose).run(suite)
if not result.wasSuccessful():
    sys.exit(1)

which I know from other projects. Added in the last release.

The other question is also raised in #24