search

gdraheim / zziplib

The ZZIPlib provides read access on ZIP-archives and unpacked data. It features an additional simplified API following the standard Posix API for file access
Other
62 stars 50 forks source link

add basic CMake based build #55

Closed paroj closed 6 years ago

paroj commented 6 years ago

as used by the OGRE specific fork - tested on all major platforms (including mobile).

Not all automake features are supported - mainly because I cannot read it.. :wink:

fixes #23

gdraheim commented 6 years ago

I do really like the patch, it looks quite sophisticated ... it is just that I do not really understand how it works. Even after a third time review I guess that I could not maintain or extend it. That's a pity because I had been thinking that it might be simpler than the autoconf/automake stuff that I know so well (ye know, I have been a maintainer for a number of years).

So how to go on with it? having another maintainer, having a hacking session? I dunno. :/

paroj commented 6 years ago

I think most of the techniques used in this patch are covered by this: https://cmake.org/cmake-tutorial/

for specific cmake commands you can also look here: https://cmake.org/cmake/help/v3.12/command/configure_file.html

most parts of this patch resolve around generating config.h like was done with autotools.

However you can just mention me when changes/ reviews are needed for the cmake build

gdraheim commented 6 years ago

It's a bit of a learning curve but I do have the build scripts back to create shared libraries with the same naming scheme as automake's libtool. So this may as well work but there are a number of make targets that need to be migrated from automake to cmake.

In any case, your config.h handling seems to be pretty perfect, thank you. From my perspective the new shared library parts could be shipped already.

For the moment I do keep it on the "develop" branch as "master" is used by downstream distro makers to provide patches. I don't want to confuse package maintainers with build system bugs that may creep in and which I can not fix in a minute.