gdrplatform / gDRcore

R package to process dose-response curve data with the GR methods
https://gdrplatform.github.io/gDRcore
1 stars 1 forks source link

changes in calculation for GR values - cover a common case #111

Closed MarcHafner closed 10 months ago

MarcHafner commented 10 months ago

Description

What changed?

Related JIRA issue: https://jira.gene.com/jira/projects/GDR/issues/GDR-2155

Why was it changed?

I found that the matching of the control by Barcode (or other nested nested_keys) is too stringent. In case there is a value for another plate, we should backfill it. This is important as Day0 plate will have another barcode by design but they are meant to be used for normalization.

Checklist for sustainable code base

Logistic checklist

Screenshots (optional)

MarcHafner commented 10 months ago

@bczech : can you review my edit and merge with master? thanks