gdrplatform / gDRcore

R package to process dose-response curve data with the GR methods

https://gdrplatform.github.io/gDRcore

1 stars 1 forks source link

Gdr 1565 #21

Closed bczech closed 1 year ago

bczech commented 1 year ago

Description

What changed?

Changed logic for parallel computing Related JIRA issue: GDR-1565

Why was it changed?

To allow for more flexible management of parallel computing parameters

Checklist for sustainable code base

[X] I added tests for any code changed/added
[X] I added documentation for any code changed/added
[X] I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

[X] Package version bumped
[X] Changelog updated

Screenshots (optional)

allisonvuong commented 1 year ago

Nice work. If the user wants to use SerialParam how can they change it? Maybe we can also add some documentation specifying to other users how the parallelization option can be changed? Not sure where to best place that such that a user would easily see it.

Minor: we could consider naming as parallelize instead of parallel to maintain our naming by verbs.

bczech commented 1 year ago

047f782

Good point, Allison! Thank you. I renamed the function and also added some information to package.R how to switch into sequential mode: 047f782