gdrplatform / gDRcore

R package to process dose-response curve data with the GR methods
https://gdrplatform.github.io/gDRcore
1 stars 1 forks source link

Debugging the isobologram function; adding isobol. calculated points … #42

Closed gladkia closed 1 year ago

gladkia commented 1 year ago

Description

Edit function to generate isobolograms in gDRcore

What changed?

https://jira.gene.com/jira/browse/GDR-1820 Related JIRA issue: https://jira.gene.com/jira/browse/GDR-1820

Why was it changed?

Avoid artifacts as seen in the data from

35 AS-39473 - 2022.09.15_USP7 Si-Han DS000013640

--> RV ; G02975672.1-5 x G03091080.1-5 ; BIO657029

--> RV ; GDC-0077 x G03091080.1-5 ; BIO657029

Checklist for the sustainable code base

Logistic checklist

Screenshots (optional)

gladkia commented 1 year ago

General changes in the PR:

gladkia commented 1 year ago

General changes in the PR:

  • version and changelog should be bumped
  • unit tests should be added for calculate_Loewe and (possibly) updated for fit_SE.

done in https://github.com/gdrplatform/gDRcore/pull/43/files.