gdrplatform / gDRcore

R package to process dose-response curve data with the GR methods

https://gdrplatform.github.io/gDRcore

1 stars 1 forks source link

Gdr 1855 #64

Closed darsoo closed 1 year ago

darsoo commented 1 year ago

Description

What changed?

Related JIRA issue:

Why was it changed?

Checklist for sustainable code base

[ ] I added tests for any code changed/added
[ ] I added documentation for any code changed/added
[ ] I made sure naming of any new functions is self-explanatory and consistent

Logistic checklist

[ ] Package version bumped
[ ] Changelog updated

Screenshots (optional)

darsoo commented 1 year ago

vignettes/gDRcore.Rmd - shouldn't be used data.table instead of data.frame in this sentece?
Provided dataset needs to be merged into the one `data.frame` object to be able to run gDR pipeline.
Question: in fucntion .clear_rownames() is condition (inherits(y, c("DFrame", "data.frame"))) - shouldn't be data.table?

Shouldn't be, data.table does not support rownames at all.

bczech commented 1 year ago

vignettes/gDRcore.Rmd - shouldn't be used data.table instead of data.frame in this sentece?
Provided dataset needs to be merged into the one `data.frame` object to be able to run gDR pipeline.
Question: in fucntion .clear_rownames() is condition (inherits(y, c("DFrame", "data.frame"))) - shouldn't be data.table?
Shouldn't be, data.table does not support rownames at all.

So it is event better, I created clear_rownames because we used data.frame so now using data.table we can get rid of clear_rownames as well since rownames shouldn't destroy our tests

bczech commented 1 year ago

GJ! 💪🏻