gdrplatform / gDRcore

R package to process dose-response curve data with the GR methods
https://gdrplatform.github.io/gDRcore
1 stars 1 forks source link

Gdr 1955 #88

Closed bczech closed 1 year ago

bczech commented 1 year ago

Description

What changed?

Fix bug in calculating isobolograms Related JIRA issue: GDR-1955

Why was it changed?

To fix bug

Checklist for sustainable code base

Logistic checklist

Screenshots (optional)

gladkia commented 1 year ago

Great job. Should some additional tests be added to protect against regression of this bug or maybe we have some tests coverting this bug already?

bczech commented 1 year ago

Great job. Should some additional tests be added to protect against regression of this bug or maybe we have some tests coverting this bug already?

We should add test once our gDRtestData will be working properly, than we can extend our testing logic for combo assays as well