search

gds-operations / vcloud-core

vCloud Core is a gem that supports automated provisioning of VMWare vCloud Director, used by the vCloud Tools gems
http://gds-operations.github.io/vcloud-tools/
MIT License
12 stars 19 forks source link

Upgrade fog from at least 1.34 to at least 1.36 #186

Closed alexmuller closed 8 years ago

alexmuller commented 8 years ago

There's a bug in fog 1.34 and 1.35 where net/ssh wasn't removed properly which is causing problems. Bumping the requirement to at least 1.36 fixes the issue.

However bumping the version of fog causes our tests to fail with the error:

     NameError:
       uninitialized constant Vcloud::Core::Logger
     # ./lib/vcloud/core.rb:31:in `logger'
     # ./spec/vcloud/core/config_loader_spec.rb:54:in `block (3 levels) in <top (required)>'

I'm not sure why this upgrade has caused that to break, but explicitly requiring the Logger class in that module fixes it.