Closed darribas closed 1 year ago
While working on this chapter, I've noticed that the TheilD
chapter works on the whole time series matrix (as does the Theil
estimator) but the Gini
estimator requires one-dimensional input.
This is a user experience/api inconsistency for giddy, I think?
I've gotten all the way through the Theil decomposition at this point. There's a lot of text that needed adding, and quite a bit that still needs to be added. It gets very sparse once the decomposition methods start.
I intend to remove:
Since there's just not enough space to explain them fully here. Alternatively, I could double down on the spatial 2020 + spatial 2020 rankpaths, but I think that's less informative?
Notes from DAB review:
we (1) don't discuss wide vs. long anywhere else in the book and (2) don't ever show a wide-to-long pivot using something like pandas.wide_to_long... We also don't need the LineCode filtering, since the final dataframe is already filtered by LineCode so that all LineCode==3.
whitegrid
but I don't know if it's used anywhere else)OK my review is in at #134. I've done quite a bit of editting and I think we can merge and then move forward.
Before the chapter is considered ready for the publisher, here're the steps I'd suggest:
To do, with/before final edits pass:
lorenz_curves.head()
--> lorenz_curves.T.head()
so it reduces the amount of printing@sjsrey is on the first final pass. To complete:
Dani final pass tracker, to be edited as we go along:
Things to ensure (from #152 ):
import pandas
)XXX
for citationsmatplotlib
RC file is picked up and figures are standard%matplotlib inline
suptitle
)ax.set_axis_off()
)This is now ready for the second final pass.
Need to resync nb and md file #191
Just going over #191 I'm not sure the bits highlighted in my previous comment have been incorporated?
https://github.com/gdsbook/book/issues/22#issuecomment-844221279
Just flagging to make sure we get them in before the three passes (e.g. removing figures with the same plots)
Bits from @darribas last pass:
PR with the rest of edits over at https://github.com/gdsbook/book/pull/207
@sjsrey any ideas for further reading on this one?
Issue to track Chapter 10 on Spatial Inequality.