search

gdscigdtuw / photo_effect

A web application that renders an effect on an image uploaded by user using python image processing libraries.
8 stars 10 forks source link

Create function for canny edge detection #16

Open apekshamanchanda opened 3 years ago

apekshamanchanda commented 3 years ago

Resource: https://docs.opencv.org/master/da/d22/tutorial_py_canny.html

Add the code in the effects.py file , a function called edge_detection has already been created there, edit that function to render the effect on the frame by referring to the above resource.

amanem1 commented 3 years ago

hi i have sent a pr , can you check and tell, what to improve.!

srishti-negi commented 3 years ago

hi i have sent a pr , can you check and tell, what to improve.!

Hey! There are a couple of issues with this pr. I have listed them below, please make the necessary changes.

  1. The function for image blurring is 'GaussianBlur' not 'gaussianBlur'.
  2. As stated in the issue, the purpose of this function was to render the effect on the frame, so instead of edges you need to modify the frame variable.
  3. There is no need to use imshow function as the purpose of the edge_detection function is to return image as a bytes object without displaying it. There is another function(out of scope of this issue) which is responsible for displaying this image.