gdsfactory / gdsfactory

python library to design chips (Photonics, Analog, Quantum, MEMs, ...), objects for 3D printing or PCBs.
https://gdsfactory.github.io/gdsfactory/
MIT License
452 stars 192 forks source link

Fix add pins triangle #2868

Closed joamatab closed 2 weeks ago

joamatab commented 2 weeks ago

fixes https://github.com/gdsfactory/gdsfactory/issues/2864

thanks to @duarte-jfs for the issue and suggested fixes

sourcery-ai[bot] commented 2 weeks ago

🧙 Sourcery is reviewing your pull request!


Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://sourcery.ai/dashboard): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 69.10%. Comparing base (232d9d8) to head (a00fcbb).

Files Patch % Lines
gdsfactory/component.py 50.00% 0 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2868 +/- ## ========================================== + Coverage 68.99% 69.10% +0.10% ========================================== Files 298 298 Lines 15348 15347 -1 Branches 2256 2256 ========================================== + Hits 10590 10605 +15 + Misses 4155 4134 -21 - Partials 603 608 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.