search

gdsfactory / kfactory

gdsfactory with a klayout backend
https://gdsfactory.github.io/kfactory/
MIT License
28 stars 10 forks source link

add update to info #271

Closed joamatab closed 3 months ago

sebastian-goeldi commented 4 months ago

What's the reason for needing this?

joamatab commented 4 months ago

we do a lot of this in gdsfactory 

c.info.update(**info_settings)
sebastian-goeldi commented 4 months ago

Then you only need the dict and not the info object one, right?

That makes this way easier. If you don't need iterable and Info object, I don't see why we should add it here. It just makes the signature unreadable.

joamatab commented 4 months ago

Yes, good point

joamatab commented 3 months ago

Looks good to me,

feel free to merge

joamatab commented 3 months ago

included in this one

https://github.com/gdsfactory/kfactory/pull/273