search

gdsfactory / kfactory

gdsfactory with a klayout backend
https://gdsfactory.github.io/kfactory/
MIT License
27 stars 10 forks source link

Drop rec_dicts flag and make it default to use rec dict inspection #375

Closed joamatab closed 3 weeks ago

joamatab commented 4 weeks ago

@sebastian-goeldi

sebastian-goeldi commented 4 weeks ago

No. This will slow it down considerably.

Best I can give you is a config flag.

And what sense does it make to enable it by default?

Just enable it in cells where it makes sense?

tvt173 commented 4 weeks ago

No. This will slow it down considerably.

Have you tried profiling or is this an assumption? I would challenge that assumption. Certainly it will slow it down, but I doubt it will be that significant.

And what sense does it make to enable it by default?

Just enable it in cells where it makes sense?

It makes it much easier to work with if you can just always do it, rather than the user needing to know they need to set that flag in the decorator of cells which take dictionary arguments... and being confused why it works sometimes but not all the time

joamatab commented 3 weeks ago

sounds good,

can we at least change the name?

i like allow_dicts