Closed doddgray closed 6 days ago
🧙 Sourcery has finished reviewing your pull request!
@sebastian-goeldi how does this look? I simplified the changes to reflect your suggestion. LMK if this needs anything else to merge.
LGTM
Can you remove that one commented line? Then I'll merge. I'll try to release soon. There are some annoying manhattan routing bugs that currently are blocking for gdsfactory to upgrade. Once I figure those out we should be good for a new release
I will make that last edit in ~3 hours.
I removed the commented print statement (line ~7600) that I think you were referencing. LMK if anything else is needed to merge.
This PR is meant to address https://github.com/gdsfactory/gdsfactory/issues/2782.
It modifies
kcell
to handle the case when it is called from an IPython kernel. Currently an IPython call causes a bug wheninspect
is used to identify the calling python file. This just adds a check to see if the "filename" looks like an IPython call and if so streams to KLayout via a temporary OAS file (inPath(tempfile.gettempdir()) / "gdsfactory"
) rather than thebuild
directory in the calling file's repository.