search

gdsfactory / kfactory

gdsfactory with a klayout backend
https://gdsfactory.github.io/kfactory/
MIT License
27 stars 10 forks source link

control_cellname_length #407

Closed joamatab closed 4 days ago

joamatab commented 1 week ago

fixes https://github.com/gdsfactory/gdsfactory/issues/2907

sourcery-ai[bot] commented 1 week ago

🧙 Sourcery has finished reviewing your pull request!

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
github-actions[bot] commented 1 week ago

Label error. Requires at least 1 of: breaking, bug, github_actions, documentation, dependencies, enhancement, feature, maintenance, security. Found:

sebastian-goeldi commented 1 week ago

I think this is not really advisable. This could create duplicate names, and it would be very much not obvious why or where that happens. What's the motivation for this?

It will still be shortened on writing.

As well as this doesn't catch

c.name = ...

Plus what do you do when you change the max_cellname_length during runtime? (I know sounds stupid but could happen with how gdsfactory currently handles pdks)

tvt173 commented 1 week ago

i agree with @sebastian-goeldi ... let the @cell decorator and/or save_layout_options take care of it...