search

gdsfactory / kfactory

gdsfactory with a klayout backend
https://gdsfactory.github.io/kfactory/
MIT License
34 stars 13 forks source link

fix #452 #454

Closed sebastian-goeldi closed 3 months ago

sourcery-ai[bot] commented 3 months ago

🧙 Sourcery has finished reviewing your pull request!

Tips - Trigger a new Sourcery review by commenting `@sourcery-ai review` on the pull request. - Continue your discussion with Sourcery by replying directly to review comments. - You can change your review settings at any time by accessing your [dashboard](https://app.sourcery.ai): - Enable or disable the Sourcery-generated pull request summary or reviewer's guide; - Change the review language; - You can always [contact us](mailto:support@sourcery.ai) if you have any questions or feedback.
nikosavola commented 3 months ago

Does the cache work correctly when you call the cell again but without post processing or with different post processing?

sebastian-goeldi commented 3 months ago

Since it's part of the decorator it's not really relevant for the cache as the cache also gets defined in the same go. KFactory does not have something like a global cache.

The issue before what that the post process loop was done after retrieval of the cell from the cached function