gdsfactory / kfactory

gdsfactory with a klayout backend
https://gdsfactory.github.io/kfactory/
MIT License
34 stars 13 forks source link

When using vinstances the cell names have "-" #485

Closed josepfargas closed 1 month ago

josepfargas commented 1 month ago

Is it possible to sanitize and replace "-" for "m" from cells names added as vinstances? example: c.create_vinst(splitter())

gives this name: splitter_MFalse_S28p0_X0p0002999883330545572_Y9p54709817424515e-06 could it be splitter_MFalse_S28p0_X0p0002999883330545572_Y9p54709817424515em06 instead?

Thanks

sebastian-goeldi commented 1 month ago

I mean, could, but why? - is fully compliant gds cellname.

josepfargas commented 1 month ago

Just to be consistent since that's the way it's done for user-Provided arguments in cells. Also tHis is breaking sOme internal tools, however we can also Go modify the iNtErnal tools. ThX!

sebastian-goeldi commented 1 month ago

Ah, ok, my mistake then. I thought we didn't change the - in other cases. I'll add it so that the full name goes through name cleaning, I thought it did already, but apparently not.

josepfargas commented 1 month ago

Thanks!