rename theta to angle - Githubissues

joamatab commented 1 year ago

more consistent with gdsfactory

codecov[bot] commented 1 year ago

Codecov Report

Merging #5 (7cf8dad) into main (276cd8a) will increase coverage by 19.67%. The diff coverage is 94.11%.

@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
+ Coverage   53.76%   73.44%   +19.67%     
===========================================
  Files          16       16               
  Lines         597      595        -2     
===========================================
+ Hits          321      437      +116     
+ Misses        276      158      -118

Impacted Files	Coverage Δ
kgeneric/cells/circular.py	`80.95% <66.66%> (-2.39%)`	:arrow_down:
kgeneric/cells/DCs.py	`88.88% <100.00%> (+62.22%)`	:arrow_up:
kgeneric/cells/__init__.py	`100.00% <100.00%> (ø)`
kgeneric/cells/euler.py	`48.14% <100.00%> (ø)`
kgeneric/cells/grating_coupler_elliptical.py	`91.66% <100.00%> (+79.76%)`	:arrow_up:

... and 2 files with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SkandanC commented 1 year ago

LGTM, I added gds files that weren't there, and also some tests

From: Joaquin Matres @.> Sent: Monday, June 5, 2023 9:38 AM To: gdsfactory/kgeneric @.> Cc: Skandan Chandrasekar @.>; Review requested @.> Subject: Re: [gdsfactory/kgeneric] rename theta to angle (PR #5)

@joamatabhttps://github.com/joamatab requested your review on: #5https://github.com/gdsfactory/kgeneric/pull/5 rename theta to angle.

— Reply to this email directly, view it on GitHubhttps://github.com/gdsfactory/kgeneric/pull/5#event-9433564460, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX72Z24WMAJERMX5K3KET5DXJXOMPANCNFSM6AAAAAAY27VN64. You are receiving this because your review was requested.Message ID: @.***>

gdsfactory / kgeneric

rename theta to angle #5

Codecov Report