Better docs - Githubissues

joamatab commented 1 year ago

How can we add klayout images of the device in the docs?

@sebastian-goeldi @SkandanC

codecov[bot] commented 1 year ago

Codecov Report

Merging #7 (c5e1370) into main (3097df0) will increase coverage by 0.04%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   85.93%   85.97%   +0.04%     
==========================================
  Files          17       16       -1     
  Lines         661      649      -12     
==========================================
- Hits          568      558      -10     
+ Misses         93       91       -2

Impacted Files	Coverage Δ
kgeneric/cells/coupler.py	`88.88% <ø> (ø)`
kgeneric/cells/grating_coupler_elliptical.py	`91.86% <75.00%> (+0.19%)`	:arrow_up:
kgeneric/cells/__init__.py	`100.00% <100.00%> (ø)`
kgeneric/cells/mzi.py	`80.26% <100.00%> (ø)`
kgeneric/tests/test_cells.py	`66.15% <100.00%> (-0.52%)`	:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SkandanC commented 1 year ago

Looks fine

From: Joaquin Matres @.> Sent: Tuesday, June 6, 2023 11:34 PM To: gdsfactory/kgeneric @.> Cc: Skandan Chandrasekar @.>; Review requested @.> Subject: Re: [gdsfactory/kgeneric] Better docs (PR #7)

@joamatabhttps://github.com/joamatab requested your review on: #7https://github.com/gdsfactory/kgeneric/pull/7 Better docs.

— Reply to this email directly, view it on GitHubhttps://github.com/gdsfactory/kgeneric/pull/7#event-9453032172, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AX72Z232BT37477Q4FB5WZLXJ7ZDFANCNFSM6AAAAAAY42RR5Q. You are receiving this because your review was requested.Message ID: @.***>

gdsfactory / kgeneric

Better docs #7

Codecov Report