gdsfactory / skywater130

skywater 130nm pdk
https://gdsfactory.github.io/skywater130/
MIT License
26 stars 11 forks source link

clean layers in YAML #60

Closed joamatab closed 1 year ago

joamatab commented 1 year ago

fixes https://github.com/gdsfactory/skywater130/issues/59

sourcery-ai[bot] commented 1 year ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 2.12%.

Quality metrics Before After Change
Complexity 0.03 ⭐ 0.06 ⭐ 0.03 πŸ‘Ž
Method Length 1042.40 β›” 766.75 β›” -275.65 πŸ‘
Working memory 4.21 ⭐ 5.14 ⭐ 0.93 πŸ‘Ž
Quality 63.94% πŸ™‚ 61.82% πŸ™‚ -2.12% πŸ‘Ž
Other metrics Before After Change
Lines 1141 704 -437
Changed files Quality Before Quality After Quality Change
sky130/config.py 67.02% πŸ™‚ 66.36% πŸ™‚ -0.66% πŸ‘Ž
sky130/layers.py 61.54% πŸ™‚ 61.56% πŸ™‚ 0.02% πŸ‘

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
sky130/layers.py get_layer_stack 0 ⭐ 354 β›” 8 πŸ™‚ 56.07% πŸ™‚ Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The πŸ‘ and πŸ‘Ž indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

codecov[bot] commented 1 year ago

Codecov Report

Merging #60 (439bba3) into main (78b1456) will increase coverage by 0.00%. The diff coverage is 80.00%.

@@           Coverage Diff           @@
##             main      #60   +/-   ##
=======================================
  Coverage   80.19%   80.20%           
=======================================
  Files          20       20           
  Lines        5676     5677    +1     
=======================================
+ Hits         4552     4553    +1     
  Misses       1124     1124           
Impacted Files Coverage Ξ”
sky130/layers.py 99.81% <75.00%> (ΓΈ)
sky130/config.py 96.77% <100.00%> (+0.10%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more