Closed joamatab closed 1 year ago
β Merging this PR will decrease code quality in the affected files by 2.12%.
Quality metrics | Before | After | Change |
---|---|---|---|
Complexity | 0.03 β | 0.06 β | 0.03 π |
Method Length | 1042.40 β | 766.75 β | -275.65 π |
Working memory | 4.21 β | 5.14 β | 0.93 π |
Quality | 63.94% π | 61.82% π | -2.12% π |
Other metrics | Before | After | Change |
---|---|---|---|
Lines | 1141 | 704 | -437 |
Changed files | Quality Before | Quality After | Quality Change |
---|---|---|---|
sky130/config.py | 67.02% π | 66.36% π | -0.66% π |
sky130/layers.py | 61.54% π | 61.56% π | 0.02% π |
Here are some functions in these files that still need a tune-up:
File | Function | Complexity | Length | Working Memory | Quality | Recommendation |
---|---|---|---|---|---|---|
sky130/layers.py | get_layer_stack | 0 β | 354 β | 8 π | 56.07% π | Try splitting into smaller methods |
The emojis denote the absolute quality of the code:
The π and π indicate whether the quality has improved or gotten worse with this pull request.
Please see our documentation here for details on how these metrics are calculated.
We are actively working on this report - lots more documentation and extra metrics to come!
Help us improve this quality report!
Merging #60 (439bba3) into main (78b1456) will increase coverage by
0.00%
. The diff coverage is80.00%
.
@@ Coverage Diff @@
## main #60 +/- ##
=======================================
Coverage 80.19% 80.20%
=======================================
Files 20 20
Lines 5676 5677 +1
=======================================
+ Hits 4552 4553 +1
Misses 1124 1124
Impacted Files | Coverage Ξ | |
---|---|---|
sky130/layers.py | 99.81% <75.00%> (ΓΈ) |
|
sky130/config.py | 96.77% <100.00%> (+0.10%) |
:arrow_up: |
:mega: Weβre building smart automated test selection to slash your CI/CD build times. Learn more
fixes https://github.com/gdsfactory/skywater130/issues/59