search

gdtiti / alembic

Automatically exported from code.google.com/p/alembic
0 stars 0 forks source link

OCurves triggers compiler warnings & errors #167

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Three issues, all in OCurves.h 
(http://code.google.com/p/alembic/source/browse/lib/Alembic/AbcGeom/OCurves.h), 
when using gcc4.1 on Linux

Issue #1 - the order of 107-114 doesn't match the order of 191-200, so a 
compiler warning is triggered
Proposal - make it consistent :)

Issue #2 - the single-value constructor in 81 isn't usable because it's 
ambiguous when compared with the multi-value constructor in 98 which has 
defaults for everything after the first argument
Proposal - remove the default value for the second argument

Issue #3 - creating a curve sample fails because in 103 the default assignment 
is of the wrong type
Proposal - change the default to FloatArraySample (from V2fArraySample)

Original issue reported on code.google.com by robpi...@gmail.com on 31 May 2011 at 8:32

GoogleCodeExporter commented 8 years ago 
This all looks spot on and Issue 1 has been fixed, though it isn't in the 
mainline just yet.

Thanks for the bug report

Original comment by ble...@gmail.com on 31 May 2011 at 5:19

GoogleCodeExporter commented 8 years ago 
This might be all, or mostly fixed now. Need to investigate

Original comment by ble...@gmail.com on 8 Jul 2011 at 2:22

GoogleCodeExporter commented 8 years ago

Original comment by ble...@gmail.com on 8 Jul 2011 at 6:23

GoogleCodeExporter commented 8 years ago 
Yeah, this was fixed back then (my bad for not closing the issue):

http://code.google.com/r/ardent-embic/source/detail?r=02482efe55d38cb6d198ee19b2
11e56543219e0d&name=default

Original comment by ard...@gmail.com on 8 Jul 2011 at 6:11

GoogleCodeExporter commented 8 years ago 
Per the call today, this issue is done and can be closed.

Original comment by scottmmo...@gmail.com on 11 Jul 2011 at 11:06