search

gdtiti / alembic

Automatically exported from code.google.com/p/alembic
0 stars 0 forks source link

Murmur3.cpp - BOOST_BIG_ENDIAN with PPC32 #205

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. Build RC1 on OS X Leopard PPC 32bit
2.
3.

What is the expected output?
Clean build.

What do you see instead?
Error in Murmur3.cpp with the bit shifting and compiler saying that
"error: integer constant is too large for ‘long’ type"

What version of the product are you using?
RC1

On what operating system?
OS X Leopard 10.5.8 PPC 32 bit

Please provide any additional information below.

Original issue reported on code.google.com by Yue.Nich...@gmail.com on 22 Jul 2011 at 1:09

GoogleCodeExporter commented 8 years ago 
Does it compile if you put ULL after the shifting constants?

0xFF00000000000000ULL

Original comment by miller.lucas on 22 Jul 2011 at 4:59

GoogleCodeExporter commented 8 years ago 
Yes, appending ULL fixed the compile issue.

I appended ULL to those offending lines (didn't want to go overboard), about 20 
of them.

After fixing the ULL problem, I found the conditional code block has a missing 
'if' keyword in the code so I fixed that too.

Attached you will find the modified file, 'ULL' and 'if' fixes that is based on 
RC1.

Apologies as I don't know how best to send a patch/diff

Original comment by Yue.Nich...@gmail.com on 22 Jul 2011 at 11:51

Attachments:

GoogleCodeExporter commented 8 years ago 
Thanks for the feedback and the file.

I went ahead and went overboard and added them to all the lines.

Change has been added here:
http://code.google.com/r/millerlucas-dev/source/detail?r=971966ec3205661288d67dd
f6c292ac89e08ac3f

Original comment by miller.lucas on 23 Jul 2011 at 12:03

GoogleCodeExporter commented 8 years ago 
Hi Yue.Nich...@gmail.com,

Thanks for submitting a contribution/fix for the issue you found. We'd love to 
include you in the list of contributors in the document included Alembic that 
acknowledges folks like yourself. In order to do so, you'd have to fill out 
this form. It's pretty fast and you can email a copy of it.

See the form here:
http://code.google.com/p/alembic/downloads/detail?name=Alembic%20Contributor%20L
icense%20Agreement%20-%20Individual.doc&can=2&q=

Thanks and hope we hear from you

-- Scott

Original comment by scottmmo...@gmail.com on 2 Aug 2011 at 1:22

GoogleCodeExporter commented 8 years ago

Original comment by miller.lucas on 12 Aug 2011 at 5:36