search

gdtk-uq / gdtk

The Gas Dynamics Toolkit (GDTk) is a set of software tools for simulating high speed fluid flow, maintained at The University of Queensland and the University of Southern Queensland, Australia.
https://gdtk.uqcloud.net/
Other
59 stars 15 forks source link

shared library missing from eilmer deployment of lua #30

Closed kyriakosTapinou closed 1 year ago

kyriakosTapinou commented 1 year ago

When trying to use external libraries with lua that use the C API, the liblua.so is required. This isn't currently built with the eilmer deployment of lua. It may be useful to include this in the lua external library directory. I've managed to cobble something together that gets gdtk to create liblua.so but it leads to failures when compiling the rest e.g eilmer. For now I've just copied liblua.so in and it runs fine for my purposes but could be a nice feature if it isn't too painful to implement.

uqngibbo commented 1 year ago

Hi Kyri,

We should be able to include it in the build of the gas library. Can you post the actual compile commands that you need?

kyriakosTapinou commented 1 year ago

Hi Nick,

the solution I found works fine for my own lua deployment. Changes made to the lua makefile in the root directory and the src directory have the commands in them that lead to building the shared library library file.

For root makefile (see https://gist.github.com/dcarrith/899047f3a2d603b25a58)

For src/makefile (see https://gist.github.com/dcarrith/6095183b8dc60c909779)

When used with the gdtk deployment of lua it crashes the install.

kyriakosTapinou commented 1 year ago

Just to follow up The shared library work around I posted works to the point of creating the shared library object but crashes the remainder of the build. I just copied the shared library object back in after the build without the hack.

I didn't actually need the shared library so I ended up linking against the static library and my external stuff works fine.