Creating 3D blocks using the TFI constructor fails with open corner errors

gdtk-uq / gdtk

The Gas Dynamics Toolkit (GDTk) is a set of software tools for simulating high speed fluid flow, maintained at The University of Queensland and the University of Southern Queensland, Australia.

https://gdtk.uqcloud.net/

Other

59 stars 15 forks source link

Creating 3D blocks using the TFI constructor fails with open corner errors #35

Closed uqngibbo closed 11 months ago

uqngibbo commented 11 months ago

Hans Hornung has found a regression where 3D blocks created in Eilmer fails to link up their constituent surfaces properly.

object.Error@(0): TFIVolume open at corner 0 p= Vector3(0, 0, -0.0099) p_alt1= Vector3(0, 0.0108566, -0.0893) p_alt2= Vector3(0, 0, -0.0893)

This seems to have something to do with commit a8a91f6fa80173d7db62ae3e88b598e8d1a62dd5, which changed the ordering of the geometry nomenclature.

uqngibbo commented 11 months ago

Fixed in 1aeeadc8.

It looks like the newTFIVolume constructor in luavolume.d had its own copy of the face order, which had not been updated when we changed to west, east, south, north, bottom, top. The order is now taken directly from `face_name' in nomenclature.d