search

gdtk-uq / gdtk

The Gas Dynamics Toolkit (GDTk) is a set of software tools for simulating high speed fluid flow, maintained at The University of Queensland and the University of Southern Queensland, Australia.
https://gdtk.uqcloud.net/
Other
59 stars 15 forks source link

Move complex numbers out of numerical methods #39

Closed Alex-Muirhead closed 9 months ago

Alex-Muirhead commented 9 months ago

The complex number module (src/nm/complex.d) is moved out of the numerical methods folder, and has a separate package created under src/ntypes/complex.

The main driver of this change is preparation for testing a dub build system, with (internal) dependency trees. Previously, there existed a dependency loop between the nm and util folders / modules, with nm.luabbla -> util.lua & util.lua_service -> nm.complex. As the complex numbers are not themselves a numerical method (i.e. root finding, finite difference, etc.), the easiest change is to move complex.d out of the nm folder / module.

uqngibbo commented 9 months ago

Oops. Why did I click that. All of this looks okay to me. Make sure you try the unit tests as well as the integration tests.

Alex-Muirhead commented 9 months ago
Alex-Muirhead commented 9 months ago

Abusing the time-travel ability of git to rebase onto the changes made to fix Issue #40