gdtk-uq / gdtk

The Gas Dynamics Toolkit (GDTk) is a set of software tools for simulating high speed fluid flow, maintained at The University of Queensland and the University of Southern Queensland, Australia.
https://gdtk.uqcloud.net/
Other
59 stars 15 forks source link

Physicality Check Allow Sketchy Temperatures #48

Closed uqngibbo closed 5 months ago

uqngibbo commented 6 months ago

Stage two of the JFNK's physicality check reduces the relaxation factor until the decode call successfully recovers the primitive variables with no exceptions getting thrown. In a couple of simulations, I have noticed a pattern where this sometimes causes problems: Specifically, the physicality check can let through extremely low (single-digit) temperatures, which are technically "physical", but cause the simulation to crash on subsequent steps.

It may be that we need a relaxation factor keyed off the change in temperature that behaves similarly to the density one.