gdumani / recipify

MIT License
0 stars 1 forks source link

Project Kanban #1

Open gdumani opened 1 year ago

gdumani commented 1 year ago

This Milestone involves the creation of the KANBAN for the Recipify project

Team members @gdumani and @jicamargo

Omar-Muhamad commented 1 year ago

Invalid ❌

Hi @gdumani and @jicamargo,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Your Code Review Request is marked as invalid for this reason:

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request Does not count into the code reviews limit.

HAMMAS-SALEEM commented 1 year ago

Required Changes :recycle:

Ukhv

Hey @gdumani, @jicamargo :wave:

Highlights :1st_place_medal:

✔️ Descriptive Issue Title ✔️ Descriptive Issue Summary ✔️ Following some requirements

Good job on implementing some of the requirements, There are some issues that you still need to work on to go to the next project but you are almost there! :blush:

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Happy coding! :clap: :clap: :clap:

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Mandatory Changes ♻️

image

Optiona Requirements 📝

cynthiainga commented 1 year ago

STATUS APPROVED ✔️ 🎉 ✔️

Hi @gdumani, @Omar-Muhamad & @jicamargo,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! 🎉

Highlights

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you take them into account as they can make your code better. Some of them were missed by the previous reviewer and addressing them will really improve your application.

Cheers, and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think the code review was unfair, you can request a second opinion using this form.