search

ge-ku / AutoJoin-for-SteamGifts

Automatically enters giveaways from Steamgifts.com
https://chrome.google.com/webstore/detail/autojoin-for-steamgifts/bchhlccjhoedhhegglilngpbnldfcidc
GNU General Public License v2.0
105 stars 22 forks source link

added detailed remaining time #31

Closed vaibhavhrt closed 6 years ago

vaibhavhrt commented 6 years ago

The span showing remaining time on each giveaway now shows a more detailed and accurate remaining time.
Two lines(200,201) of code added to change the text of span and one function added at the bottom of file to change time in seconds to d:h:m :s and return a string to be placed inside the span.

ge-ku commented 6 years ago

Seems like it returns wrong values in some cases. For example secToTime(88400) returns "33m:20sec". I think it's because the number of hours in this case is 0 and it skips number of days entirely. Can you fix this?

vaibhavhrt commented 6 years ago

Sure i will fix it today. I need to reverse the order conditions in if-else

vaibhavhrt commented 6 years ago

Done it should be fixed now. Test it yourself first just to be sure then merge, if there are any other issues let me know.

ge-ku commented 6 years ago

Looks good, I'll upload it to the Chrome store when I reach my PC.

vaibhavhrt commented 6 years ago

thanks 😺